Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Improvement] Create a builder constructor for Neural Query Builder #1025

Open
bzhangam opened this issue Dec 17, 2024 · 1 comment
Open
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed Refactoring Improve the design, structure, and implementation while preserving its functionality

Comments

@bzhangam
Copy link
Contributor

Is your feature request related to a problem?

No

What solution would you like?

Create a builder constructor for Neural Query Builder similar to KNNQueryBuilder.

  1. Give us the flexibility that we don't need to pass all parameters when some optional ones are not needed when we want to construct a new Neural Query Builder.
  2. Adding a new parameter will not break the existing tests which doesn't care about it.

What alternatives have you considered?

N/A

Do you have any additional context?

N/A

@martin-gaievski martin-gaievski added Refactoring Improve the design, structure, and implementation while preserving its functionality good first issue Good for newcomers help wanted Extra attention is needed and removed enhancement labels Dec 18, 2024
@heemin32 heemin32 moved this to Backlog in Neural Search RoadMap Dec 26, 2024
@will-hwang
Copy link

assign this to me please

@heemin32 heemin32 moved this from Backlog to Backlog(Hot) in Neural Search RoadMap Jan 3, 2025
@heemin32 heemin32 moved this from Backlog(Hot) to 2.19 in Neural Search RoadMap Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed Refactoring Improve the design, structure, and implementation while preserving its functionality
Projects
Status: 2.19
Development

No branches or pull requests

4 participants