Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove map-zoom CSS class scaffolding if it's never used #105

Open
anselmbradford opened this issue May 5, 2014 · 0 comments
Open

Remove map-zoom CSS class scaffolding if it's never used #105

anselmbradford opened this issue May 5, 2014 · 0 comments

Comments

@anselmbradford
Copy link
Member

While addressing #101, I thought I would attach CSS classes to the different map zoom levels, but instead added a .trail-selected class. However, I left the scaffolding for being able to add custom CSS to different zoom levels, as this is potentially useful. However, if this is never used it should be removed. The code for this is found in the following locations:

https://github.com/codeforamerica/trails-mobile/blob/master/www/js/application/controllers.js#L223

https://github.com/codeforamerica/trails-mobile/blob/master/www/js/application/controllers.js#L318

and

https://github.com/codeforamerica/trails-mobile/blob/master/www/js/application/controllers.js#L324

The scaffolding adds a class to map-container that looks like, e.g.map-zoom-10 (the number of which updates based on whatever zoom level the map is on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants