Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video content should be given with a wallpaper #55

Closed
kelson42 opened this issue May 4, 2023 · 3 comments
Closed

Video content should be given with a wallpaper #55

kelson42 opened this issue May 4, 2023 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@kelson42
Copy link
Contributor

kelson42 commented May 4, 2023

If I try to look to a video, I get this (before clicking on the "play" button)
image

I want to have a proper image displayed in place of this grey box.

Either this is delivered in the json or we should find a way to capture one from the video stream.

@kelson42 kelson42 added the enhancement New feature or request label May 4, 2023
@rgaudin
Copy link
Member

rgaudin commented May 4, 2023

The player displays the first frame of the video as cover. This series of videos happen to start with a blank grey image.

We could extract any random frame to create a dedicated thumbnail but we'd loose control over what gets picked up while every video tool uses the first frame (unless they allow choosing one). That's what's expected.

I am thus in favor of closing this. We could remove the blank frames and redo this ZIM as well.

Screenshot 2023-05-04 at 14 41 42

@kelson42
Copy link
Contributor Author

kelson42 commented May 4, 2023

Not sure how the solution should look like but I know we should not display a grey or black box for a video.

Using the first frame of a video is not what I expect, and it's not how it works usually. See Youtube, Netflix, etc.

I think the reason is obvious: it's just not what user expect, they want to get a picture which give an idea - is representive - of the content.

We should:

  • either find a way to encourage publish to submit a poster
  • find a smart algo to capture automatically a representive frame of the video

@kelson42 kelson42 added the question Further information is requested label May 4, 2023
@rgaudin
Copy link
Member

rgaudin commented May 5, 2023

Closing in favor of #56 #57

@rgaudin rgaudin closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants