Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove No-check Defaults Options Passed To PTOSC #19

Open
paulrrogers opened this issue Aug 14, 2019 · 1 comment · May be fixed by #20
Open

Remove No-check Defaults Options Passed To PTOSC #19

paulrrogers opened this issue Aug 14, 2019 · 1 comment · May be fixed by #20
Assignees
@paulrrogers
Labels
enhancement New feature or request

Comments

@paulrrogers
Copy link
Contributor

paulrrogers commented Aug 14, 2019 •
edited
Loading

Defaulting to --no-check-unique-key-change and --no-check-alter may be inappropriate for some users. Dropping these as defaults from OnlineMigrator makes it safer for first-time users and removes one limitation from the README.md. And those who still want them can still set those in their config or PTOSC_OPTIONS.

Since this would technically be a backward incompatible change it should also bump the major version number, if it won't already change for the next release.
@paulrrogers paulrrogers added the enhancement New feature or request label Aug 14, 2019
@paulrrogers paulrrogers changed the title Review Default Options Passed To PTOSC Remove No-check Defaults Options Passed To PTOSC Aug 14, 2019
@paulrrogers
Copy link
Contributor Author

Perhaps instead of dropping --no-check-unique-key-change the PTOSC recommended check(s) should be run by OM, unless user explicitly opts into PTOSC's --check-unique-key-change.

If PTOSC checks unique keys by default it will halt progress until user does it anyway, possibly leading to users turning it off without running checks.

@paulrrogers paulrrogers self-assigned this Aug 14, 2019
@paulrrogers paulrrogers linked a pull request Aug 14, 2019 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulrrogers paulrrogers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@paulrrogers