Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Guide uses deprecated code #114

Closed
sebthom opened this issue Dec 4, 2020 · 4 comments
Closed

Developer Guide uses deprecated code #114

sebthom opened this issue Dec 4, 2020 · 4 comments

Comments

@sebthom
Copy link
Contributor

sebthom commented Dec 4, 2020

The example in the https://github.com/jkuhnert/ognl/blob/master/docs/DeveloperGuide.md#embedding-ognl uses deprecated code and should be updated:

public Object getValue(OgnlContext context, Object rootObject) throws OgnlException {
   return Ognl.getValue(getExpression(), context, rootObject); // <-- deprecated
}

What is a non-deprecated alternative that resembles the same functionality?

@lukaszlenart
Copy link
Collaborator

It was deprecated because it was using addDefaultContext() without providing implementation of MemberAccess, but I added a default implementation sometime ago and now the deprecation doesn't make sense. Fixed that!

@sebthom
Copy link
Contributor Author

sebthom commented Dec 17, 2020

@lukaszlenart I think you forgot to de-deprecate the Ognl.getValue methods in the code.

@lukaszlenart
Copy link
Collaborator

Good catch, fixed! OGNL 3.2.18 is under way!

@sebthom
Copy link
Contributor Author

sebthom commented Dec 18, 2020

@lukaszlenart thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants