-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeConverter / OgnlOps 'double boxing' #25
Comments
Great! I would rather push a new version based on #24 and then merge this one (and push new release), it's a safer path :) |
@sa-ChristianNiessner you are free to go with this :) |
And here it is. Just got the mails about the 3.1.5 release ;) |
I see no objections, merge party! |
lukaszlenart
added a commit
that referenced
this issue
May 19, 2016
Pull-Request for Isuse #25 - TypeConverter / OgnlOps 'double boxing'
Fixed by merging #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I just pushed a new branch that also addresses another 'inconsistency' issue I was fighting in the past:
The automatic Type-Conversion puts a List (or Collection) into an array by doing new Object[] { } instead of using the items of the list for the array. I think this would be the more desired behaviour. I also fixed the related unit tests from #16 / #19 respectively and added some new tests.
The commit [410dee5](secadm@410dee5f64410f98ad4171150dc19869abd7de4c] (branch TypeConverterDoubleArrayBoxing) addresses the issue.
This patch is based on #23 / #24 and so i'll create a pull request after #24 ist merged or the pull request will also provide #24. But maybe both requests can be reviewed together.
Bye,
Chris
The text was updated successfully, but these errors were encountered: