Slash in consumer name results in folders being created

[TimothyJones]

Software versions

• OS: Mac OSX 10.11.6 (15G1611)
• Consumer Pact library: Pact JS 4.2.1
• Provider Pact library: NA
• Node Version: v8.3.0

When the consumer or provider names contain a slash, the slash is passed through to the file system, which creates folders:

Expected behaviour

Full pact filename is present in the pacts/ folder, something like: pacts/a_b client-a_b api.json

Alternatively, some kind of error that provider/consumer names are not allowed to contain slashes.

Actual behaviour

Pact file in a few folders deep: pacts/a/b client-a/b api.json

Steps to reproduce

Use the following pact() call:

  const provider = pact({
    consumer: 'A/B Client',
    provider: 'A/B API',
    port,
    done: error => expect(error).to.be.null
  });

[bethesque]

I'm trying to think of an example where a service name would have a slash in it! But yes, we should do one of the two.

[bethesque]

Can you raise this in the pact-mock_service repository? That's where the logic is.

[TimothyJones]

The example we have is an API for A/B testing. I'll raise the issue over there now.

[TimothyJones]

Done: pact-foundation/pact-mock_service#81

I suppose we should close this one now?

[mefellows]

I think it's an acceptable string to use, I would suggest we properly escape the names and let it be used (and not created the subfolders).

[mefellows]

Let's leave this open for the time being until we understand if changes are required here also.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[TimothyJones]

Changes were not required :)