Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation of root level patterns in navigation confusing #1341

Open
renestalder opened this issue Aug 3, 2021 · 3 comments
Open

Indentation of root level patterns in navigation confusing #1341

renestalder opened this issue Aug 3, 2021 · 3 comments
Labels
good first issue 🎓 hacktoberfest 🌾 https://hacktoberfest.digitalocean.com

Comments

@renestalder
Copy link

I am using Pattern Lab Node v5.15.0 on Linux, with Node v16.0.0, using a Vanilla/Twig Edition.

The visual hierarchy of the menu items is off due to the used indentation.

Expected Behavior

The patterns on the first level in the navigation should be in one line with the groups/folders of that level. The next level then should have the indentation.

Screenshot from 2021-08-03 15-21-18
Screenshot from 2021-08-03 15-21-57

Actual Behavior

Both level of items have the same indentation, thus seems to be in the same visual hierarchy, while in reality, they are not.
Users aren't able to visually distinct the items of the group/folder "tag" from the rest of the elements that are outside of the group.

Screenshot from 2021-08-03 15-16-44

Screenshot from 2021-08-03 15-17-02

Steps to Reproduce
  1. Create an example pattern_patterns/test/test-1.twig and an example pattern _patterns/test/test-group/test-2.twig.
  2. See the result listed in the navigation as "Test", with a group "Test Group" and an item "Test 1".
  3. Expand "Test Group" to show the item "Test 2".
@mfranzke
Copy link
Contributor

mfranzke commented Aug 7, 2021

@renestalder thanks a lot for this important and well-documented issue.

Do you have the chance to even also analyze the problem further and provide a solution via a pull request?
The background of my question is that this project is mainly "backed" by the contributions from the community, be it feedback or even bugfixes and optimizations, and the project would highly benefit by spreading the workload over several shoulders. I even also found myself struggling with some issues before and then started to contribute to the product myself; so especially if these are important topics to you, this would heavily speed up the process to bring those into the product as well.
If you can't that's fine too, maybe somebody else could take up those tasks.

@renestalder
Copy link
Author

I will take a look at this.

@stale
Copy link

stale bot commented Jan 9, 2022

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@mfranzke mfranzke added the hacktoberfest 🌾 https://hacktoberfest.digitalocean.com label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🎓 hacktoberfest 🌾 https://hacktoberfest.digitalocean.com
Projects
None yet
Development

No branches or pull requests

3 participants