Allow custom icons for DefaultTaskGroup

[jpuzz0]

A design requirement for Openshift AI is to allow for BanIcon to be used instead of the default 'Canceled' task icon.

Default presentation for DefaultTaskGroup for the 'Canceled' task node state:

Desired outcome: The warning icon to be replaced by some user defined icon.

The ability to overwrite the mapping for what icons map to what RunStatus at a broader level in a topology view could also be a solution to this problem.

[dlabaj]

@jenny-s51 @jpuzz0 Do you know the urgency of this issue?

[jenny-s51]

Hi @jpuzz0 ! Topology currently provides support for a customStatusIcon that you can use in TaskNode.tsx.

You can see an example of this in action in our demo app (look for Pipelines -> Task Nodes), where the BanIcon is passed in to the "Custom Status Icon Task" node:

react-topology/packages/demo-app-ts/src/demos/pipelinesDemo/useDemoPipelineNodes.tsx

Lines 284 to 285 in 02f6fbe

	status: RunStatus.Failed,
	customStatusIcon: <BanIcon />,

Does this help with your use case?

[jpuzz0]

@jenny-s51 I don't think so. I'm using DefaultTaskGroup, not TaskNode. I have no issue with using custom icons for TaskNode.

[jpuzz0]

@dlabaj

@jenny-s51 @jpuzz0 Do you know the urgency of this issue?

I would consider it normal urgency

[andrewballantyne]

@dlabaj

@jenny-s51 @jpuzz0 Do you know the urgency of this issue?

I would consider it normal urgency

@jpuzz0 and I talked about this in Standup. I feel this is a bit higher than normal as it is confusing to the user to "what is the feedback you want me to get from the warning". I would not consider this critical, but in there is a status between normal and critical I feel it is probably that. Better to fix this than let it linger imo.

[jenny-s51]

Closed via #246