Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vorbis decoder panics with end of stream #235

Closed
dvdsk opened this issue Oct 12, 2023 · 2 comments
Closed

Vorbis decoder panics with end of stream #235

dvdsk opened this issue Oct 12, 2023 · 2 comments

Comments

@dvdsk
Copy link

dvdsk commented Oct 12, 2023

The ogg test file in rodio breaks symphonia. When running the example code (modified with type hint .ogg) it crashes with:

thread 'main' panicked at src/main.rs:67:17:
end of stream

I have attached the file:
music.zip
You can also download it directly from:
https://github.com/RustAudio/rodio/blob/master/assets/music.ogg

It only broke a test, its not blocking me, feel free to give this a low priority.

@pdeljanov
Copy link
Owner

Based the output you provided, it looks like Symphonia returned an end-of-stream error that wasn't handled by the application. I also don't get any panics when I decode the file with symphonia-play. So I'm not sure this is a bug. Could you provide a backtrace?

@dvdsk
Copy link
Author

dvdsk commented Jan 16, 2024

Based the output you provided, it looks like Symphonia returned an end-of-stream error that wasn't handled by the application.

Ill be honest, I do not fully understand what the Rodio code is doing. On first glance it seems like the Symphonia decoder is immediately returning end-of-stream. The use of Symphonia in Rodio wildly differs from the examples provided by Symphonia. I'am in the process of clarifying/refactoring that code.

Once that's done Ill take another look, if the issue is still there ill reopen.

@dvdsk dvdsk closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants