Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop parsing a column named "limits" as the LIMIT keyword #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop parsing a column named "limits" as the LIMIT keyword #208

wants to merge 1 commit into from

Conversation

choroba
Copy link
Member

@choroba choroba commented Jun 29, 2024

Fixes #205.

@choroba choroba force-pushed the limit branch 2 times, most recently from 118dea6 to 63f6204 Compare June 30, 2024 16:55
michal-josef-spacek
michal-josef-spacek reviewed Dec 12, 2024
View reviewed changes
t/35limit.t Outdated
@@ -75,4 +75,24 @@ SQL

ok($dbh->do("DROP TABLE dbd_mysql_t35"));

# Issue #205: A table named "limits" shouldn't be parsed as LIMIT.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is column not table.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Ready to squash.

@choroba choroba changed the title Stop parsing a table named "limits" as the LIMIT keyword Stop parsing a column named "limits" as the LIMIT keyword Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michal-josef-spacek michal-josef-spacek michal-josef-spacek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong enum value on insert/update if colum name contains string "limit"
2 participants
@choroba @michal-josef-spacek