Attribute Error Fix in assign.py
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
apetkau
approved these changes
Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ISSUE12, which caused
AttributeErrors during cluster address assignment when using 2 or fewer levels inGAS version 0.1.2.The issue occurred because
data[sample_id]values could be non-strings (e.g., floats/integers), causing anAttributeErrorwhen attempting to call.split()on these numeric types.To fix this, cluster addresses are now converted to strings before splitting by the specified delimiterto ensure compatibility regardless of the data type inferred by pandas in the
format_dffunction of theassign.pyclass.Cluster address assignment with 2 or fewer levels can now be run through
gas calland has been tested locally.