Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Option to include or remove 0s in semilog scale #128

Open
2 tasks
js3110 opened this issue Nov 19, 2024 · 1 comment
Open
2 tasks

Enhancement: Option to include or remove 0s in semilog scale #128

js3110 opened this issue Nov 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@js3110
Copy link
Collaborator

js3110 commented Nov 19, 2024

Description

Linked to #127
Option for users in log and mean plots to either filter out the 0s for log scale plots, or include them for visualisation of BLQs.

Definition of Done

The requirements for the feature to be complete:

  • Checkbox to include or remove 0s
  • Individual plots function correctly and log scale transforms correctly
@billdenney
Copy link

Copied from #135

I would recommend removing the breaks and labels from the log lineplot here and allow the default to be used. These breaks and labels may cause high concentrations (e.g. 100000) not to have a label. The default method in the scales package should work well, and the scales method covers edge cases. (E.g. What if all concentrations are in a small range like 3 to 7? That would be unusual but could happen for pharmacodynamic NCA.)

aNCA/R/general_lineplot.R

Lines 141 to 142 in 9c19cdd

scale_y_log10(breaks = c(0.001, 0.01, 0.1, 1, 10, 100, 1000),
label = c(0.001, 0.01, 0.1, 1, 10, 100, 1000)) +

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants