Chore: customize github workflows to correctly install system dependencies #151
+354
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kolomanski
changed the title
|
Thank you for making this change, and confirming that it works! Considering that #146 is still in review, let's wait - maybe we get some meaningful suggestions in pharmaverse/admiralci. If #146 is ready before we get an answer, then let's proceed as we discussed - copy over the workflow files, modify them to install dependencies, and reference them from the main workflow. |
Gero1999
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #149
Also resolves issues with checks in PR #146
Description
Reworks and customizes github workflows. Instead of relying on reusable workflows provided by admiralci, each of the needed workflows is inlined in the main workflow. This means that the jobs can be customizable in terms of correct installing of system deps, as well as efficiency. The drawback being that the workflows will need periodical, manual maintenance when updates are available.
How to test
Currently the PR also changes the DESCRIPTION, adding the
unitspackage, which has problematic system dependencies. With the changes, all checks pass. Before merging, changes to the DESCRIPTION file should be removed.