Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Automatic selection of grouping vars #155

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

js3110
Copy link
Collaborator

@js3110 js3110 commented Jan 7, 2025

Issue

Closes #154

Description

For column mapping at the moment, grouping variables are selected manually by the user. However it would be useful if some columns are automatically selected if they are present in the data.

Main columns used for grouping:
TRTA
TRTAN
ACTARM
TRT01A
TRT01P
AGE
RACE
SEX
For pre-clinical: GROUP

Definition of Done

The requirements for the feature to be complete:

  • Automatic selection of above columns in the 'Grouping Variables' selectInput in the Mapping section.
  • If the columns are not present, input box still works as normal and columns can be manually selected
  • If some but not all of the columns are present, the ones included should be automatically selected with no issues.

How to test

Mapping and Filters section -> Grouping Variables

Contributor checklist

  • Code passes lintr checks
  • Code passes all unit tests
  • New logic covered by unit tests
  • New logic is documented

@js3110 js3110 linked an issue Jan 7, 2025 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@Shaakon35 Shaakon35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, it works

Copy link
Collaborator

@m-kolomanski m-kolomanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there is one very minor issue.

inst/shiny/functions/mapping_selectize_inputs.R Outdated Show resolved Hide resolved
@js3110 js3110 requested a review from m-kolomanski January 7, 2025 17:19
Copy link
Collaborator

@m-kolomanski m-kolomanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@js3110 js3110 merged commit c55ac67 into main Jan 8, 2025
9 checks passed
@js3110 js3110 deleted the enhancement/selection-of-grouping branch January 8, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Automatic selection of Grouping Variables
3 participants