-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations will be lost on next publication from main. #235
Comments
Also tagging @jbphet because he is our string guy! |
Thanks for the tag. Before the next release, I'd recommend looking through the changes and seeing how many translated strings were lost. If it's a bunch, we can manually port the strings into their scenery-phet equivalents. It seems like a shame to lose a bunch of work done by our trusted translators. |
It is 4 strings, as seen in bed5c0f. (8 total), but 4 are in the PDOM and so untranslatable. These 4 strings are not just blanketly moved to common code, but converted into patterns that are filled in based on the the object the combo box is changing ("Solutes" in molarity's case, "Challenges" in RaP). I don't think it will be possible to convert, but maybe it won't be too hard to ask them to patch them in to the new version? |
Yes, we have done that before. We can give @oliver-phet a list of the affected locales and and explanation of what has changed and he'll communicate with the trusted translators. |
Over in #234, we removed sim-specific content, including string keys in molarity, in exchange for new ones over in scenery-phet for a common code component. This issue is supposed to be similar to phetsims/gravity-force-lab#166 in that molarity-specific translations will be no longer used as those keys are deleted.
I think there is a good chance though that by the time this is published again, the scenery-phet strings will all be translated from use in another sim, perhaps there will be some automatic work done on that front. Noting this for next release.
The text was updated successfully, but these errors were encountered: