-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Voicing to ComboBox #243
Comments
This has been implemented, and I also added a PreferencesConfiguration() object so that we can test this. It is easiest to run the sim from master with |
This has been implemented, though tweaks are still being made to phetsims/sun#726. Once that issue is closed, @Matthew-Moore240 can take a listen here. |
We have had a design sign-off in common code. over to @Matthew-Moore240 to review. |
As a simple test, it would be awesome to add voicing here. This comes from updating common code (see phetsims/sun#726).
We can use https://docs.google.com/document/d/1-BMIhvNV07MUaMk0-b205mvM3735EZvyKUl6ILUTGq4/edit#heading=h.92mxf0hs6osk
Tagging @Matthew-Moore240 that I may get to this, to help test ComboBox voicing pretty soon, but of course we can make tweaks afterwards to the strings.
The text was updated successfully, but these errors were encountered: