ddl puller(ticdc): add UTs for schema version check removal in DDL #11822
+84
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wlwilliamx
changed the title
ti-chi-bot
bot
added
the
size/M
wlwilliamx
changed the title
|
/cc @asddongmen @lidezhu |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11820
What is changed and how it works?
This PR introduces a unit test to validate the handling of schema version disorder in TiCDC’s DDL job processing logic.
Background
Previously, TiCDC enforced a schema version check that discarded DDL jobs with schema versions smaller than the current schema version, even if their commit timestamps were valid. This logic was removed in #11733 to allow processing of DDL jobs based on commit timestamps alone, improving robustness in handling schema version disorder.
This ensures TiCDC can robustly handle schema version disorder without discarding valid DDL jobs, aligning with the recent removal of schema version checks.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note