Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply changes in Pinpoint v3.0.0 #184

Open
ga-ram opened this issue Dec 21, 2023 · 3 comments
Open

Apply changes in Pinpoint v3.0.0 #184

ga-ram opened this issue Dec 21, 2023 · 3 comments

Comments

@ga-ram
Copy link
Contributor

ga-ram commented Dec 21, 2023

  • hbase version 1 -> 2
  • java version 11 -> 17 for web and collector
  • property name changes
    • JDBC_DRIVERCLASSNAME -> x
    • JDBC_URL -> SPRING_DATASOURCE_HIKARI_JDBCURL, SPRING_METADATASOURCE_HIKARI_JDBCURL
    • JDBC_USERNAME -> SPRING_DATASOURCE_HIKARI_USERNAME, SPRING_METADATASOURCE_HIKARI_USERNAME
    • JDBC_PASSWORD -> SPRING_DATASOURCE_HIKARI_PASSWORD, SPRING_METADATASOURCE_HIKARI_PASSWORD
    • PINPOINT_PINOT_JDBC_URL -> SPRING_PINOTDATASOURCE_HIKARI_JDBCURL
    • PINPOINT_PINOT_JDBC_USERNAME -> SPRING_PINOTDATASOURCE_HIKARI_USERNAME
    • PINPOINT_PINOT_JDBC_PASSWORD -> SPRING_PINOTDATASOURCE_HIKARI_PASSWORD
  • redis added for realtime active requests
ga-ram added a commit to ga-ram/pinpoint-docker that referenced this issue Dec 21, 2023
@ga-ram
[pinpoint-apm#184] Apply changes in Pinpoint v3.0.0
dbe1be1
ga-ram added a commit to ga-ram/pinpoint-docker that referenced this issue Dec 27, 2023
@ga-ram
[pinpoint-apm#184] Apply changes in Pinpoint v3.0.0
d96ac45
ga-ram added a commit that referenced this issue Dec 27, 2023
@ga-ram
[#184] Apply changes in Pinpoint v3.0.0
f5bcb0c
ga-ram added a commit to ga-ram/pinpoint-docker that referenced this issue Jun 4, 2024
@ga-ram
[pinpoint-apm#184] Add new kafka topics and pinot tables, fix wrong e…
c949e2f 
…nvironment variables
ga-ram added a commit that referenced this issue Jun 4, 2024
@ga-ram
[#184] Add new kafka topics and pinot tables, fix wrong environment v…
21223d4 
…ariables
@jakeinflab
Copy link

thank you, @ga-ram. Any plan to merge sir?

@jakeinflab
Copy link 

PINPOINT_PINOT_JDBC_URL      -> SPRING_PINOTDATASOURCE_HIKARI_JDBCURL  -> SPRING_PINOT_DATASOURCE_PINOT_JDBC_URL
PINPOINT_PINOT_JDBC_USERNAME -> SPRING_PINOTDATASOURCE_HIKARI_USERNAME -> SPRING_PINOT_DATASOURCE_PINOT_USERNAME
PINPOINT_PINOT_JDBC_PASSWORD -> SPRING_PINOTDATASOURCE_HIKARI_PASSWORD -> SPRING_PINOT_DATASOURCE_PINOT_PASSWORD

from pinot-jdbc.properties

@kojandy
Copy link

kojandy commented Oct 23, 2024

These changes have already been merged to the repository.
You can refer to the PRs below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ga-ram @kojandy @jakeinflab