-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JOSS] Error running matchpoint.ipynb #80
Comments
Hi @malmans2. I am able to reproduce this. I've pinned it down to an upgrade to numpy 3 days ago breaking something within hvplot. Downgrading numpy to 1.24.3 seems to fix the problem. I'll put together a reproducible example and raise an issue over at hvplot. It seems to only apply to cases with multiple depths, and the numpy change appears to be changing the behaviour of xarray which is causing the problem in hvplot. |
Did you end up opening an issue? If yes, I would add the reference here. |
I thought I had closed this off. My bad. This should now work fine. Updates to panel broke ncplot in web browsers in May, and my "fixes" meant files like this weren't plotting. But it should be fine in ncplot v0.3.5. |
This is now working, so I'm closing the issue. A couple of things I noticed tho:
|
Thanks. I've just raised an issue. This only impacts macOS, and I've been meaning to fix it for a while. #92 I'll double check the deprecation warnings. Last time I looked there was nothing within nctoolkit itself throwing the warnings, it was purely hvplot. So little that could be done in nctoolkit itself. |
Describe the bug
I'm getting a plotting issue when I try this: https://nctoolkit.readthedocs.io/en/latest/matchpoint.html
I tried both the latest and the stable version of nctoolkit, and I'm using Jupyter Lab.
To Reproduce
Expected behavior
Reproduce documentation plot.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
openjournals/joss-reviews#5494
The text was updated successfully, but these errors were encountered: