-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<View> with postprocessing #1413
Comments
Hi ! Here is a sandbox showing it : https://codesandbox.io/s/view-skissor-forked-qm8zzl?file=/src/App.js I think it's a bug, never found how to make it work... Did you solve it ? Thanks :) |
I have the same issue, temporarily replacing the view with scissor. |
I also have this issue/requirement |
same :) |
View does not support Postprocessing out of the box as postprocessing requires Line 138 in 7186407
With composerRef.current.render() where Like in this CSB: https://codesandbox.io/p/sandbox/viewcube-forked-vhhxks?file=%2Fsrc%2FSceneWrapper.js%3A59%2C1-60%2C1 However, please note that you will have canvas background alpha issues as Postporcessing passes were not built with |
I figured it out, finally, just a minute ago. Yay :) took me a couple of days. I've got split views, each with their own DPR settings, each with their own EffectComposer and different Effects, which stack according to their order in the code, with full transparency support. What still bothers me:
|
Now even working with the original View.tsx from Drei with transparency 🥳: It requires a slightly modified EffectComposer, due to the issue / bug mentioned here: pmndrs/react-postprocessing#285 It's basically a wrapper for View.tsx. The key to make it work, apart from the fix to EffectComposer above, is to include the EffectComposer into each View where post processing should take place and disabling it. Rendering of EffectComposer passes is handled by the wrapper. To allow transparency, each View is rendered to a texture and applied to ScreenQuad with a shader material. Works great. One thing I noticed though, Drei's View behaves strange when scrolling, I don't know why this happens. It doesn't happen in this example https://codesandbox.io/p/sandbox/r9w2ob but it does also happen in other examples from the Drei docs. Any suggestions welcome. |
Thank you for contributing! We’re marking this issue as stale as a gentle reminder to revisit it and give it the attention it needs to move forward. Any activity, like adding an update or comment, will automatically remove the stale label so it stays on our radar. Feel free to reach out on Discord if you need support or feedback from the community. This issue will close automatically soon if there’s no further activity. Thank you for understanding and for being part of the project! |
We’re closing this issue to keep our project manageable and make room for other active work, but we truly appreciate your effort and contribution. If you’d like to continue working on this, please feel free to re-open it or reach out on Discord — our community is always ready to support you. Thanks again for helping us stay organized and for understanding our approach! |
What is your question:
Hey! Was following the Next.js react-three fiber example, which uses the drei View component. I wanted to add a postprocessing effect to the whole canvas, but, alas, without success. Was wondering if anyone had any experience integrating the two?
The text was updated successfully, but these errors were encountered: