Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name devStore functions #2910

Merged
merged 2 commits into from
Jan 6, 2025
Merged

name devStore functions #2910

merged 2 commits into from
Jan 6, 2025

Conversation

dmaskasky
Copy link
Collaborator

@dmaskasky dmaskasky commented Jan 6, 2025

Summary

Name dev store functions.

Check List

  • pnpm run fix:format for formatting code and docs

@dmaskasky dmaskasky requested a review from dai-shi January 6, 2025 05:27
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 9:24am

Copy link

codesandbox-ci bot commented Jan 6, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 6, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2910

commit: ad79aaf

Copy link

github-actions bot commented Jan 6, 2025

Size Change: +38 B (+0.04%)

Total Size: 92.6 kB

Filename Size Change
./dist/esm/vanilla.mjs 4.32 kB +11 B (+0.26%)
./dist/system/vanilla.development.js 4.42 kB +8 B (+0.18%)
./dist/umd/vanilla.development.js 5.79 kB +8 B (+0.14%)
./dist/vanilla.js 5.68 kB +11 B (+0.19%)
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 932 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.19 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react.mjs 1.4 kB
./dist/esm/react/utils.mjs 746 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla/utils.mjs 5.04 kB
./dist/index.js 242 B
./dist/react.js 1.44 kB
./dist/react/utils.js 1.39 kB
./dist/system/babel/plugin-debug-label.development.js 1.1 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.29 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react.development.js 1.56 kB
./dist/system/react.production.js 864 B
./dist/system/react/utils.development.js 860 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla.production.js 2.23 kB
./dist/system/vanilla/utils.development.js 5.25 kB
./dist/system/vanilla/utils.production.js 3.14 kB
./dist/umd/babel/plugin-debug-label.development.js 1.08 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react.development.js 1.57 kB
./dist/umd/react.production.js 936 B
./dist/umd/react/utils.development.js 1.53 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla.production.js 2.9 kB
./dist/umd/vanilla/utils.development.js 6.24 kB
./dist/umd/vanilla/utils.production.js 3.78 kB
./dist/utils.js 247 B
./dist/vanilla/utils.js 6.1 kB

compressed-size-action

Copy link

github-actions bot commented Jan 6, 2025

LiveCodes Preview in LiveCodes

Latest commit: ad79aaf
Last updated: Jan 6, 2025 9:14am (UTC)

Playground Link
React demo https://livecodes.io?x=id/GK3MFYQL8

See documentations for usage instructions.

@dmaskasky dmaskasky changed the title label atomStates label atomStates in devMode Jan 6, 2025
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I don't feel like merging this. named functions instead of anonymous functions are okay, if that helps.

src/vanilla/store.ts Outdated Show resolved Hide resolved
src/vanilla/store.ts Outdated Show resolved Hide resolved
@dmaskasky dmaskasky changed the title label atomStates in devMode name devStore functions Jan 6, 2025
@dmaskasky dmaskasky requested a review from dai-shi January 6, 2025 09:15
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally prefer anonymous functions for minification, but this is good because it's DEV only.

@dai-shi dai-shi merged commit 91af445 into main Jan 6, 2025
43 checks passed
@dai-shi dai-shi deleted the atomstate-labels branch January 6, 2025 10:23
@dai-shi dai-shi added this to the v2.11.1 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants