-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/unstable): expose internals instead of unstable_derive #2911
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Size Change: +953 B (+1.04%) Total Size: 93 kB
ℹ️ View Unchanged
|
Preview in LiveCodesLatest commit: f130ff6
See documentations for usage instructions. |
Wow, this is incredibly powerful and flexible. I appreciate that it doesn't allow direct mutation of an existing store's internal functions, yet provides all the necessary tools to build a new store if you know what you’re doing. This might be overkill for jotai-scope, but it’s reassuring to have this flexibility available. My only concern is that exposing more of the API can be daunting to anyone who looks under the hood. It might be preferable to group these exports under a single |
I don't like objects, as they are not minifyable. Let me try a namespace. |
This actually doesn't work as current rollup config. Let me revert it. I can do it again with a follow-up PR. (Can't do it in this PR as it conflicts too much.) |
I think this should come with a new minor. |
Following #2905, I think we could provide some internal functions because
unstable_derive
turns out to be somewhat limited.