From d405f2395d5ebba134bb84884fae6557cc3f2a56 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sat, 4 Jan 2025 00:40:24 +0900 Subject: [PATCH 1/4] chore(.github/workflows): change 'node-version' to 'lts/*' in 'actions/setup-node' --- .github/workflows/compressed-size-action.yml | 2 +- .github/workflows/cr.yml | 2 +- .github/workflows/lint-and-type.yml | 2 +- .github/workflows/livecodes-preview.yml | 2 +- .github/workflows/publish.yml | 2 +- .github/workflows/test-multiple-builds.yml | 2 +- .github/workflows/test-multiple-versions.yml | 4 ++-- .github/workflows/test-old-typescript.yml | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/compressed-size-action.yml b/.github/workflows/compressed-size-action.yml index 278d0b2a01..e55467c687 100644 --- a/.github/workflows/compressed-size-action.yml +++ b/.github/workflows/compressed-size-action.yml @@ -10,7 +10,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* cache: 'pnpm' - uses: preactjs/compressed-size-action@v2 with: diff --git a/.github/workflows/cr.yml b/.github/workflows/cr.yml index 0ea400905e..b9235fe86c 100644 --- a/.github/workflows/cr.yml +++ b/.github/workflows/cr.yml @@ -10,7 +10,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* cache: 'pnpm' - run: pnpm install - run: pnpm build diff --git a/.github/workflows/lint-and-type.yml b/.github/workflows/lint-and-type.yml index f13ceb8058..085d119f16 100644 --- a/.github/workflows/lint-and-type.yml +++ b/.github/workflows/lint-and-type.yml @@ -14,7 +14,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* cache: 'pnpm' - run: pnpm install - run: pnpm test:format diff --git a/.github/workflows/livecodes-preview.yml b/.github/workflows/livecodes-preview.yml index e50ab1b21f..0df6318587 100644 --- a/.github/workflows/livecodes-preview.yml +++ b/.github/workflows/livecodes-preview.yml @@ -10,7 +10,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* cache: 'pnpm' - uses: live-codes/preview-in-livecodes@v1 with: diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 8613b881d3..797a0ccbad 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -12,7 +12,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* registry-url: 'https://registry.npmjs.org' cache: 'pnpm' - run: pnpm install diff --git a/.github/workflows/test-multiple-builds.yml b/.github/workflows/test-multiple-builds.yml index b1e26e7140..86032372f4 100644 --- a/.github/workflows/test-multiple-builds.yml +++ b/.github/workflows/test-multiple-builds.yml @@ -19,7 +19,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* cache: 'pnpm' - run: pnpm install - run: pnpm build diff --git a/.github/workflows/test-multiple-versions.yml b/.github/workflows/test-multiple-versions.yml index 82d0fb8614..871a180c17 100644 --- a/.github/workflows/test-multiple-versions.yml +++ b/.github/workflows/test-multiple-versions.yml @@ -14,7 +14,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* cache: 'pnpm' - run: pnpm install - run: pnpm build # we don't have any other workflows to test build @@ -40,7 +40,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* cache: 'pnpm' - run: pnpm install - name: Install legacy testing-library diff --git a/.github/workflows/test-old-typescript.yml b/.github/workflows/test-old-typescript.yml index 1943c6068d..674dc6deae 100644 --- a/.github/workflows/test-old-typescript.yml +++ b/.github/workflows/test-old-typescript.yml @@ -36,7 +36,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: lts/* cache: 'pnpm' - run: pnpm install - run: pnpm build From b2a08771f678e498adeb403a9feb710629f0287c Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sat, 4 Jan 2025 00:40:52 +0900 Subject: [PATCH 2/4] chore(.github/workflows/ecosystem-ci.yml): change 'node-version' to 'latest' in 'actions/setup-node' --- .github/workflows/ecosystem-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ecosystem-ci.yml b/.github/workflows/ecosystem-ci.yml index 57fc1511ce..548a7e5ea9 100644 --- a/.github/workflows/ecosystem-ci.yml +++ b/.github/workflows/ecosystem-ci.yml @@ -15,7 +15,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 22 + node-version: latest cache: 'pnpm' - run: pnpm install - name: Get Short SHA From 79a7bdf37616465082cce201b843c578ec496840 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sat, 4 Jan 2025 01:52:29 +0900 Subject: [PATCH 3/4] chore(.github/workflows): add single quote for consistency --- .github/workflows/compressed-size-action.yml | 2 +- .github/workflows/cr.yml | 2 +- .github/workflows/ecosystem-ci.yml | 2 +- .github/workflows/lint-and-type.yml | 2 +- .github/workflows/livecodes-preview.yml | 2 +- .github/workflows/publish.yml | 2 +- .github/workflows/test-multiple-builds.yml | 2 +- .github/workflows/test-multiple-versions.yml | 4 ++-- .github/workflows/test-old-typescript.yml | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/compressed-size-action.yml b/.github/workflows/compressed-size-action.yml index e55467c687..56d40ca57a 100644 --- a/.github/workflows/compressed-size-action.yml +++ b/.github/workflows/compressed-size-action.yml @@ -10,7 +10,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' cache: 'pnpm' - uses: preactjs/compressed-size-action@v2 with: diff --git a/.github/workflows/cr.yml b/.github/workflows/cr.yml index b9235fe86c..8f379b5dd3 100644 --- a/.github/workflows/cr.yml +++ b/.github/workflows/cr.yml @@ -10,7 +10,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' cache: 'pnpm' - run: pnpm install - run: pnpm build diff --git a/.github/workflows/ecosystem-ci.yml b/.github/workflows/ecosystem-ci.yml index 548a7e5ea9..d26551d7a6 100644 --- a/.github/workflows/ecosystem-ci.yml +++ b/.github/workflows/ecosystem-ci.yml @@ -15,7 +15,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: latest + node-version: 'latest' cache: 'pnpm' - run: pnpm install - name: Get Short SHA diff --git a/.github/workflows/lint-and-type.yml b/.github/workflows/lint-and-type.yml index 085d119f16..e1ddc722fb 100644 --- a/.github/workflows/lint-and-type.yml +++ b/.github/workflows/lint-and-type.yml @@ -14,7 +14,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' cache: 'pnpm' - run: pnpm install - run: pnpm test:format diff --git a/.github/workflows/livecodes-preview.yml b/.github/workflows/livecodes-preview.yml index 0df6318587..20453e0102 100644 --- a/.github/workflows/livecodes-preview.yml +++ b/.github/workflows/livecodes-preview.yml @@ -10,7 +10,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' cache: 'pnpm' - uses: live-codes/preview-in-livecodes@v1 with: diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 797a0ccbad..01ed803f95 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -12,7 +12,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' registry-url: 'https://registry.npmjs.org' cache: 'pnpm' - run: pnpm install diff --git a/.github/workflows/test-multiple-builds.yml b/.github/workflows/test-multiple-builds.yml index 86032372f4..e4a50b1b95 100644 --- a/.github/workflows/test-multiple-builds.yml +++ b/.github/workflows/test-multiple-builds.yml @@ -19,7 +19,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' cache: 'pnpm' - run: pnpm install - run: pnpm build diff --git a/.github/workflows/test-multiple-versions.yml b/.github/workflows/test-multiple-versions.yml index 871a180c17..9ebcfec50f 100644 --- a/.github/workflows/test-multiple-versions.yml +++ b/.github/workflows/test-multiple-versions.yml @@ -14,7 +14,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' cache: 'pnpm' - run: pnpm install - run: pnpm build # we don't have any other workflows to test build @@ -40,7 +40,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' cache: 'pnpm' - run: pnpm install - name: Install legacy testing-library diff --git a/.github/workflows/test-old-typescript.yml b/.github/workflows/test-old-typescript.yml index 674dc6deae..a168a6cf9b 100644 --- a/.github/workflows/test-old-typescript.yml +++ b/.github/workflows/test-old-typescript.yml @@ -36,7 +36,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + node-version: 'lts/*' cache: 'pnpm' - run: pnpm install - run: pnpm build From 0abb0a4fc4404dc84ad2363382ae17a1620ad8fe Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sat, 4 Jan 2025 10:33:32 +0900 Subject: [PATCH 4/4] Update .github/workflows/ecosystem-ci.yml Co-authored-by: Daishi Kato --- .github/workflows/ecosystem-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ecosystem-ci.yml b/.github/workflows/ecosystem-ci.yml index d26551d7a6..57fc1511ce 100644 --- a/.github/workflows/ecosystem-ci.yml +++ b/.github/workflows/ecosystem-ci.yml @@ -15,7 +15,7 @@ jobs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 'latest' + node-version: 22 cache: 'pnpm' - run: pnpm install - name: Get Short SHA