Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r3f v9 (react 19) error in Effectcomposer #301

Open
chrisweb opened this issue Oct 22, 2024 · 4 comments · May be fixed by #302
Open

r3f v9 (react 19) error in Effectcomposer #301

chrisweb opened this issue Oct 22, 2024 · 4 comments · May be fixed by #302

Comments

@chrisweb
Copy link

I created a reproduction repository for an error in the react postprocessing effectcomposer when using the latest r3f v9 beta 1 package (as well as next.js 15 / react 19)

The error message that gets catched by Next.js is the following:

TypeError: Cannot read properties of undefined (reading 'length')

which corresponds to line 139 https://github.com/pmndrs/react-postprocessing/blob/master/src/EffectComposer.tsx#L139 in the typescript source file

I wasn't sure if this repository is the right place to open an issue, as r3f v9 transitioned to a reconciler (previously core renderer) due to heavy changes in react 19, I assume the problem in the effectcomposer might be related to those changes

@ChronoByteCosmonaut
Copy link

Same issue 👍

@VrTech
Copy link

VrTech commented Nov 23, 2024

We might need to consider updating Effectcomposer to match react 19 as well 👍

@Priyansh4444
Copy link

Priyansh4444 commented Nov 29, 2024

The error message I am getting with children?
TypeError: children2 is undefined
"@react-three/drei": "^9.117.3",
"@react-three/fiber": "^9.0.0-alpha.8",
"@react-three/postprocessing": "^2.16.3",
"next": "^15.0.3",
"react": "^19.0.0-rc.1",

          <EffectComposer>
        <Bloom
          mipmapBlur
          levels={3}
          opacity={0.25}
          intensity={0.5}
          luminanceThreshold={0.31}
          luminanceSmoothing={0.71}
        />
      </EffectComposer>

Anything I could do?

@teneburu
Copy link

teneburu commented Dec 6, 2024

same issue !
TypeError: children2 is undefined
"@react-three/drei": "9.120.0",
"@react-three/fiber": "9.0.0-rc.1",
"@react-three/postprocessing": "^2.16.3",
"next": "^15.0.4",
"react": "^19.0.0-rc.1",

please help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants