From 26200a6cd87db443b26e895002dd9df6ea15614b Mon Sep 17 00:00:00 2001 From: Joost Schildwacht Date: Fri, 20 Oct 2023 21:00:24 +0200 Subject: [PATCH] remove unused config settings --- NEWS.md | 16 ++++++++++------ Plugin/Model/Checkout/LayoutProcessorPlugin.php | 6 ------ composer.json | 6 +++--- etc/config.xml | 15 --------------- view/base/web/js/postcode-handler/postcode-be.js | 2 +- view/base/web/js/postcode-handler/postcode-de.js | 2 +- 6 files changed, 15 insertions(+), 32 deletions(-) diff --git a/NEWS.md b/NEWS.md index 091c70d..3874a48 100644 --- a/NEWS.md +++ b/NEWS.md @@ -14,6 +14,7 @@ to: ```text V5: https://api.postcodeservice.com/nl/v5/find?zipcode=4201KB&houseno=63 +See https://developers-staging.postcodeservice.com/#netherlands-api ``` - Added support for Belgium bilingual results in bilingual municipalities, @@ -38,7 +39,7 @@ V3: https://api.postcodeservice.com/be/v3/zipcode-find?zipcodezone=1050&multires "city": "Bruxelles", "latitude": 50.8222854, "longitude": 4.3815707 - } + }, ... ] ``` @@ -92,7 +93,8 @@ if (data.error_code) { - Revised and updated the Magento User manual to ensure it matches the latest changes. - Updated `SECURITY.md` with GitHub’s private reporting option, providing a secure channel for issue reporting. -- Successfully tested the extension with the new Magento 2.4.7-beta1, Magento 2.4.7-beta2, confirming compatibility and +- Successfully tested the extension with the new Magento 2.4.7-beta1, Magento 2.4.7-beta2, + confirming compatibility and performance. ## UX/UC improvements @@ -102,13 +104,14 @@ if (data.error_code) { in `postcode-nl.js`, see comment `// The last parameter is the delay in millisecond` in the file. - Similarly, decreased the loading speed of the address results for Belgium from 500 milliseconds to - 50 milliseconds for + 30 milliseconds for streets and 30 milliseconds for zipcodes by default. This can be changed in `postcode-be.js`, see twice the comment `// Parameter for the results delay in milliseconds`. - Eliminated the redundant loading screen for Nederlands in Magento Checkout, enhancing the overall user experience in the vanilla Magento Luma checkout theme. You can still turn this on in the - file `postcode-api.js` in the method `getPostCodeNL` by setting the variable `showLoader: false` to `true`. + file `postcode-api.js` in the method `getPostCodeNL` by setting the variable `showLoader: false` + to `true`. - Deactivated advanced settings that were not being utilized, thereby simplifying the user interface. - Added new documentation links from within the extension to the Magento User manual and underlying @@ -144,5 +147,6 @@ if (data.error_code) { ## Release credits -- Thanks go out to the following people for contributing to this release: Robert, Tim S., Vincent, Erik de - Groot, Viktoriia and Peter S. +- Thanks go out to the following people for contributing to this release: Robert, Tim S., Vincent, + Erik de + Groot, Viktoria and Peter S. diff --git a/Plugin/Model/Checkout/LayoutProcessorPlugin.php b/Plugin/Model/Checkout/LayoutProcessorPlugin.php index 6ab8892..4b87d7b 100644 --- a/Plugin/Model/Checkout/LayoutProcessorPlugin.php +++ b/Plugin/Model/Checkout/LayoutProcessorPlugin.php @@ -249,12 +249,6 @@ public function afterProcess($subject, $jsLayout) { // @TODO use a better way to set sort order for postcode field, // tried in branch "tryout_billing_address_sortorder_mixin" - // @TODO remove debug data - /* $file = fopen('test.txt', 'a+'); - fwrite($file, $defaultCountry . "--"); - fclose($file); - */ - if ($defaultCountry === "NL" || $defaultCountry === "BE" || $defaultCountry === "DE") { $jsLayout = $this->arrayManager->set($postalCodePath . '/config/sortOrder', $jsLayout, 50); } diff --git a/composer.json b/composer.json index f3d4170..bae928e 100644 --- a/composer.json +++ b/composer.json @@ -13,14 +13,14 @@ { "name": "TIG", "email": "support@postcodeservice.com", - "homepage": "https://postcodeservice.nl/" + "homepage": "https://postcodeservice.com" } ], "support": { "email": "support@postcodeservice.com", - "issues": "https://portal.tig.nl" + "issues": "https://postcodeservice.com/support/" }, - "homepage": "https://postcodeservice.nl/", + "homepage": "https://postcodeservice.com", "minimum-stability": "RC", "autoload": { "files": [ diff --git a/etc/config.xml b/etc/config.xml index a9a9216..f531867 100644 --- a/etc/config.xml +++ b/etc/config.xml @@ -64,21 +64,6 @@ 1 1 - - 30 - - - 30 - 8 - 50 - 6 - - - 30 - 8 - 50 - 6 - diff --git a/view/base/web/js/postcode-handler/postcode-be.js b/view/base/web/js/postcode-handler/postcode-be.js index a402bd5..e4aad6d 100644 --- a/view/base/web/js/postcode-handler/postcode-be.js +++ b/view/base/web/js/postcode-handler/postcode-be.js @@ -214,7 +214,7 @@ define( streetField.attr('autocomplete', 'yes'); streetField.autocomplete({ - delay: 50, // Parameter for the results delay in milliseconds + delay: 30, // Parameter for the results delay in milliseconds source: function (street, response) { var postcode = currentPostcodeService.getElement(FieldTypes.postcode).value(); var city = currentPostcodeService.getElement(FieldTypes.city).value(); diff --git a/view/base/web/js/postcode-handler/postcode-de.js b/view/base/web/js/postcode-handler/postcode-de.js index 21437c0..4274f64 100644 --- a/view/base/web/js/postcode-handler/postcode-de.js +++ b/view/base/web/js/postcode-handler/postcode-de.js @@ -214,7 +214,7 @@ define( streetField.attr('autocomplete', 'yes'); streetField.autocomplete({ - delay: 50, // Parameter for the results delay in milliseconds + delay: 30, // Parameter for the results delay in milliseconds source: function (street, response) { var postcode = currentPostcodeService.getElement(FieldTypes.postcode).value(); var city = currentPostcodeService.getElement(FieldTypes.city).value();