Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenbids adapter depends on a none existing file in tests #3629

Closed
muuki88 opened this issue Dec 16, 2024 · 1 comment
Closed

Greenbids adapter depends on a none existing file in tests #3629

muuki88 opened this issue Dec 16, 2024 · 1 comment

Comments

@muuki88
Copy link
Contributor

muuki88 commented Dec 16, 2024

The GreenbidsRealTimeDataProcessedAuctionRequestHookTest seems to try downloading a, what seems to be pirated version of MaxMinds GeoLite database. We should remove this for many reasons (external dependencies, probably pirated db, no offline tests possible, random failures if files not available)

The project even explicitly removes older releases:
https://github.com/P3TERX/GeoLite.mmdb/blob/3bd5ebd7734fcdb863b0d92b96d2e6aa3c1580f4/.github/workflows/GeoLite.yml#L74-L77

Error log

From https://github.com/prebid/prebid-server-java/actions/runs/12314480990/job/34370688356?pr=3622#step:6:7155

Error:  Errors: 
Error:    GreenbidsRealTimeDataProcessedAuctionRequestHookTest.setUp:96->givenDatabaseReader:343 » FileNotFound https://github.com/P3TERX/GeoLite.mmdb/releases/download/2024.12.13/GeoLite2-Country.mmdb
Error:    GreenbidsRealTimeDataProcessedAuctionRequestHookTest.setUp:96->givenDatabaseReader:343 » FileNotFound https://github.com/P3TERX/GeoLite.mmdb/releases/download/2024.12.13/GeoLite2-Country.mmdb
Error:    GreenbidsRealTimeDataProcessedAuctionRequestHookTest.setUp:96->givenDatabaseReader:343 » FileNotFound https://github.com/P3TERX/GeoLite.mmdb/releases/download/2024.12.13/GeoLite2-Country.mmdb
Error:    GreenbidsRealTimeDataProcessedAuctionRequestHookTest.setUp:96->givenDatabaseReader:343 » FileNotFound https://github.com/P3TERX/GeoLite.mmdb/releases/download/2024.12.13/GeoLite2-Country.mmdb
@AntoxaAntoxic
Copy link
Collaborator

Fixed in #3624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants