Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace support #97

Open
purge opened this issue Oct 28, 2013 · 5 comments
Open

Namespace support #97

purge opened this issue Oct 28, 2013 · 5 comments

Comments

@purge
Copy link
Collaborator

purge commented Oct 28, 2013

use a different name from 'sqwidget' for data-sqwidget components for fully conflict free use

@adhipg
Copy link
Collaborator

adhipg commented Oct 29, 2013

Sure, do we say something like data-config-* instead?

@purge
Copy link
Collaborator Author

purge commented Oct 29, 2013

No I mean the actual name is configurable. It's really low priority 


Sent from Mailbox for iPhone

On Tue, Oct 29, 2013 at 9:01 AM, Adhip Gupta [email protected]
wrote:

Sure, do we say something like data-config-* instead?

Reply to this email directly or view it on GitHub:
#97 (comment)

@adhipg
Copy link
Collaborator

adhipg commented Oct 29, 2013

Okay. That doesn't really matter. We can just send in everything data-* other than data-sqwidget (the widget url) to the widget as the settings. That means that the widget can decide what they want to use.

@adhipg adhipg mentioned this issue Nov 7, 2013
@zawilliams
Copy link

Is this actually in place to pull in data-*? I'm having trouble getting it to work. Would like to use this for a project and remove "sqwidget" in the embeddable code to keep a custom data attribute.

@adhipg
Copy link
Collaborator

adhipg commented Jul 25, 2014

We never got around to making this configurable. You need to use data-sqwidget-* to get items in config at present.
It should be relatively simple to change 'sqwidget' to something else.

I will possibly have a crack at fixing this over the weekend so that everything in data-* ends up in the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants