Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting cold run to 0 #35

Open
VitalyChait opened this issue Dec 22, 2024 · 0 comments
Open

Setting cold run to 0 #35

VitalyChait opened this issue Dec 22, 2024 · 0 comments

Comments

@VitalyChait
Copy link

VitalyChait commented Dec 22, 2024

Hi, is it possible to set cold_run = 0 ?
Seems as
if I set "warm_runs": 1 and "cold_runs": 0 - I get 2 runs instead of one run (The runs are 1 cold, 1 warm - from the log)

The nested JSON configurations mention below:

--- stream1.json
{
    "description": "stream 1",
    "start_on_new_client": true,
    "catalog": "######",
    "query_files": [
      "../../../../../queries/tpch/03.sql",
      "../../../../../queries/tpch/18.sql",
      "../../../../../queries/tpch/05.sql"
    ],
    "expected_row_counts": {
      "tpch_sf1000_": [
        10,
        100,
        1,
        0,
        4,
        1,
        112013,
        2,
        27840,
        20,
        30,
        20,
        2,
        1,
        1,
        7,
        4,
        5
      ]
    },
    "cold_runs": 0,
    "warm_runs": 1
}
--- stream2.json
{
    "description": "stream 2",
    "start_on_new_client": true,
    "catalog": "######",
    "query_files": [
      "../../../../../queries/tpch/06.sql",
      "../../../../../queries/tpch/14.sql",
      "../../../../../queries/tpch/16.sql"
    ],
    "expected_row_counts": {
      "tpch_sf1000_": [
        1,
        1,
        27840,
        1,
        20,
        20,
        2,
        1,
        7,
        2,
        4,
        30,
        100,
        4,
        5,
        112013,
        10,
        0
      ]
    },
    "cold_runs": 0,
    "warm_runs": 1
}
--- stream3.json
{
    "description": "stream 3",
    "start_on_new_client": true,
    "catalog": "######",
    "query_files": [
      "../../../../../queries/tpch/08.sql",
      "../../../../../queries/tpch/05.sql",
      "../../../../../queries/tpch/04.sql"
    ],
    "expected_row_counts": {
      "tpch_sf1000_": [
        2,
        1,
        5,
        1,
        4,
        4,
        100,
        7,
        1,
        20,
        20,
        0,
        112013,
        1,
        30,
        27840,
        2,
        10
      ]
    },
    "cold_runs": 0,
    "warm_runs": 1
}
--- Parent configuration (generated_pbench_config.json)
{
    "description": "Run the 3 streams",
    "schema": "tpch_sf1k",
    "save_output": true,
    "save_json": true,
    "save_column_metadata": true,
    "next": [
      "/home/####/stream1_daxl.json",
      "/home/####/tpt_stream2_daxl.json",
      "/home/####/tpt_stream3_daxl.json",
      "/home/####/post_query_configs/post_config.json"
    ]
}

Running the Pbench args (high-level)

pbench run -c ###### -n test_name -s http://####/ -o /tmp /home/####/generated_pbench_config.json

From the Pbench logs:

{"level":"info","benchmark_stage_id":"stream3","query_file":"../../../../../queries/tpch/08.sql","query_index":0,"cold_run":true,"sequence_no":0,"info_url":"http://####/ui/query.html?20241220_175717_00001_wgtcv","catalog":"#####","schema":"tpch_sf1k","save_output":true,"save_column_metadata":true,"time":"2024-12-20T19:57:17+02:00","message":"submitted query"}
{"level":"info","benchmark_stage_id":"stream3","query_file":"../../../../../queries/tpch/08.sql","query_index":0,"cold_run":true,"sequence_no":0,"info_url":"http://####/ui/query.html?20241220_175717_00001_wgtcv","query_id":"20241220_175717_00001_wgtcv","row_count":2,"start_time":"2024-12-20T19:57:17+02:00","finish_time":"2024-12-20T19:57:52+02:00","duration_in_seconds":34.889958633,"time":"2024-12-20T19:57:52+02:00","message":"query finished"}
{"level":"info","benchmark_stage_id":"stream3","query_file":"../../../../../queries/tpch/08.sql","query_index":0,"cold_run":true,"sequence_no":0,"info_url":"http://####/ui/query.html?20241220_175717_00001_wgtcv","time":"2024-12-20T19:57:52+02:00","message":"query data saved successfully"}

{"level":"info","benchmark_stage_id":"stream3","query_file":"../../../../../queries/tpch/08.sql","query_index":0,"cold_run":false,"sequence_no":1,"info_url":"http://####/ui/query.html?20241220_175752_00012_wgtcv","catalog":"":"#####","","schema":"tpch_sf1k","save_output":true,"save_column_metadata":true,"time":"2024-12-20T19:57:52+02:00","message":"submitted query"}
{"level":"info","benchmark_stage_id":"stream3","query_file":"../../../../../queries/tpch/08.sql","query_index":0,"cold_run":false,"sequence_no":1,"info_url":"http://####/ui/query.html?20241220_175752_00012_wgtcv","query_id":"20241220_175752_00012_wgtcv","row_count":2,"start_time":"2024-12-20T19:57:52+02:00","finish_time":"2024-12-20T19:58:18+02:00","duration_in_seconds":25.704920262,"time":"2024-12-20T19:58:18+02:00","message":"query finished"}
{"level":"info","benchmark_stage_id":"stream3","query_file":"../../../../../queries/tpch/08.sql","query_index":0,"cold_run":false,"sequence_no":1,"info_url":"http://####/ui/query.html?20241220_175752_00012_wgtcv","time":"2024-12-20T19:58:18+02:00","message":"query data saved successfully"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant