Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Make variable Typr p5.Fonts use the same variables as the 2D canvas #7447

Open
2 of 17 tasks
davepagurek opened this issue Dec 24, 2024 · 1 comment
Open
2 of 17 tasks

Comments

@davepagurek
Copy link
Contributor

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build process
  • Unit testing
  • Internationalization
  • Friendly errors
  • Other (specify if possible)

p5.js version

dev-2.0

Web browser and version

Firefox

Operating system

MacOS

Steps to reproduce this

Currently, if you load a variable font (e.g. test/manual-test-examples/type/font/BricolageGrotesque-Variable.ttf) in WebGL mode, word wrapping and measurement is currently broken because the parameters that Typr seems to read are different than the variables picked by default by the 2D canvas, which is what is used for measurement.

Typr now supports reading variable font data (photopea/Typr.js#56) so it seems like after updating Typr, we should be able to make these match!

One other complication: We currently associate one FontInfo (containing font bezier cache data for WebGL) with one font:

p5.js/src/webgl/text.js

Lines 687 to 690 in 05e35cb

let fontInfo = this.states.textFont._fontInfo;
if (!fontInfo) {
fontInfo = this.states.textFont._fontInfo = new FontInfo(font);
}

However, we will need a new FontInfo whenever any variable changes for the font, as that will change all the bezier data. So we likely will also need to have a cache by variable value in the font (possibly using a lot of memory if these change a lot? maybe needing an LRU cache to evict old ones?), or just invalidate the existing font info whenever variables change (possibly slow if this is animating every frame.)

@davepagurek davepagurek changed the title [2.0] Make Typr p5.Fonts use the same variables as the 2D canvas [2.0] Make variable Typr p5.Fonts use the same variables as the 2D canvas Dec 24, 2024
@dhowe
Copy link
Contributor

dhowe commented Dec 24, 2024

I'm in the process of adding the updated Typr version into our repo (and then hopefully into an npm package), so this should be ready soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants