Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port more Examples to p5.js #235

Closed
8 tasks done
REAS opened this issue Aug 12, 2021 · 7 comments · Fixed by #309
Closed
8 tasks done

Port more Examples to p5.js #235

REAS opened this issue Aug 12, 2021 · 7 comments · Fixed by #309
Labels

Comments

@REAS
Copy link
Member

REAS commented Aug 12, 2021

Some of the examples on the website have still images instead of live code. Try to port these to p5.js and run them as code on the site. These include:

  • Lights/Directional
  • Lights/Mixture
  • Lights/Mixture Grid
  • Lights/On Off
  • Lights/Reflection
  • Lights/Spot
  • Transform/Rotate Push Pop
  • Transform/Rotate X Y

I don't think it's possible to load SVGs and OBJs directly in p5.js right now? If that's true, we'll need to leave all of the examples in the Shape category as image placeholders.

@REAS REAS added the Examples label Aug 12, 2021
@SableRaf
Copy link
Collaborator

p5.js can load OBJs directly using the loadModel() function

p5.js doesn't support svg loading natively but it can be done using p5.js-svg (https://github.com/zenozeng/p5.js-svg)
Question: should interactive examples be allowed to use additional js libraries if needed to emulate Processing (Java) behavior?

Happy to take care of those

@trikaphundo
Copy link
Contributor

I took on all the examples @REAS listed and I have just issued a PR. The only one that I did not manage to get to work is the Spot example.

@REAS
Copy link
Member Author

REAS commented Aug 22, 2022

Thank you @trikaphundo! @SableRaf you'll have full admin privileges for this repo to accept this PR when you accept the invite :)

@SableRaf SableRaf reopened this Aug 22, 2022
@SableRaf
Copy link
Collaborator

I merged @trikaphundo's fixes (thanks!) and edited the original issue to add tasks for the Shapes section.

@trikaphundo
Copy link
Contributor

Hello @SableRaf, you have marked the example Lights/Spot as work done in your edit of the initial comment; but my PR #309 didn't fix it.
I have just checked the main branch to see whether, maybe, some other person fixed it, but the example's folder was last modified a year ago.

Therefore, Lights/Spot should be set back to TODO work.
Greetings.

@SableRaf
Copy link
Collaborator

Good catch! That was a mistake. Back in the TODOs \o

@SableRaf
Copy link
Collaborator

I moved the SVG discussion to a separate issue: #314

Closing this as the examples mentioned in the original issue have been ported. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants