Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect aria syntax #12

Open
sandbergja opened this issue Jan 6, 2020 · 1 comment
Open

Incorrect aria syntax #12

sandbergja opened this issue Jan 6, 2020 · 1 comment

Comments

@sandbergja
Copy link
Contributor

The dropdown currently has the "menu" role. According to the ARIA standard, elements with the "menu" role need to have child elements with the menuitem role.

I am not an accessibility expert, but I am not sure the "menu" role is even the best fit for the dropdown, so the best option might be to just remove that role.
@sandbergja sandbergja mentioned this issue Jan 9, 2020
Open
@sandbergja
Copy link
Contributor Author

Opened PR #15 to resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sandbergja