Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add GPS EXIF tool for auto-placing images using embedded GPS EXIF data #795

Closed
jywarren opened this issue Nov 17, 2020 · 1 comment
Closed

Comments

@jywarren
Copy link
Member

#142 introduced this awesome feature, which uses image metadata to try to place images roughly over their real-world positions on the globe. Compass data is also used to try to guess appropriate image rotation.

Unfortunately this feature is not shown in the demo and i think it may need a little help to get featured more prominently and/or debugged; it's not in the README either:

image

Ideally it should be present in the default toolbar and:

  • should be enabled if EXIF data is present
  • should show a tooltip No GPS EXIF metadata found if not
  • should be documented in the README
  • should be covered by a test (using sample images below! Note that EXIF tags should survive an image resize so if we want a test image we can use a small one for efficiency.)

We had used a crosshairs icon in the past for this tool.

Example images and known expected locations

I think a solution for this is already up at #421 but may need updating/refactoring. Sample images and a sample use case can be found at https://publiclab.org/notes/patcoyle/03-23-2015/using-the-mapknitter-2-image-placement-using-geotagged-images and should lead to placement as shown here:

image

Related code links

Noting related code not only at the PR above (#421) but also at:

Thanks all!

@jywarren
Copy link
Member Author

jywarren commented Oct 1, 2022

Moving to #1024

@jywarren jywarren closed this as completed Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant