"Notes" tab missing from question page

[jywarren]

Our topic pages have tabs for "notes" and "questions":

https://publiclab.org/tag/infragram

When the questions tab is open, you can get back to notes with the notes tab:

https://publiclab.org/questions/tag/infragram

However, questions are actually just notes tagged with a special tag, question:TOPICNAME -- for example, for topic infragram, above, the tag is question:infragram.

Unfortunately, there's a bug with the tab display where if you accidentally go to this address, you see no "notes" tab at all:

https://publiclab.org/tag/question:infragram

Shouldn't we just remove this conditional wrapping that first tab?

plots2/app/views/tag/show/_nav_tabs.html.erb

Lines 5 to 15 in f979980

	<% unless params[:id].match("question:") %>
	<li class="nav-item">
	<a class="nav-link <% if @node_type == "note" %> active<% end %>" href="/tag/<%= params[:id] %>">
	<i class="fa fa-file"></i>
	<span class="d-lg-inline">
	<span class="d-none d-md-inline"><%= t('tag.show.research_notes') %></span>
	<span class="d-none d-sm-inline badge badge-primary"><%= params[:counts][:posts] %></span>
	</span>
	</a>
	</li>
	<% end %>

---

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

---

[pydevsg]

Nice catch @jywarren 😃
I agree with the same, we should remove the conditional wrapping .

[TildaDares]

Hi @pydevsg, this issue doesn’t really follow the formatting that FTOs usually have. I think it would be best to leave it as an fto-candidate instead.

[ishikajn8126]

Hey @jywarren!
I would like to work on this!

[TildaDares]

Hi @ishikajn8126, please go ahead. If you need any assistance, feel free to reach out.

[ishikajn8126]

Hi @ishikajn8126, please go ahead. If you need any assistance, feel free to reach out.

Sure, thanks.

[EECvision]

Hi @TildaDares, I am an outreachy applicant. Please can I work on this issue if it is still open?

[stephaniequintana]

Hi, @ishikajn8126 - I'm just dropping a quick line to see if you would like any help on this issue. If so, @EECvision just commented that he would like to work on it, too. I can also help if you would like. Please feel free to reach out to either of us.

For me, the biggest hurdle was getting my environment setup. I see here that you may have the same problem I ran into. Please see my reply and reach out if that is the case.

Happy coding!

[jywarren]

@ishikajn8126 have you completed a first-timers-only issue already? If you have, perhaps you'd like to try reposting this issue as a first-timers-only issue for someone else?

However, otherwise please go ahead and thanks everyone for offering support! 🎉

[ishikajn8126]

Hey @stephaniequintana @jywarren!! I'm facing some issue in my environment setup, I'm working on it, will open a PR as soon as I get it ready..

[Forchapeatl]

Hey @stephaniequintana @jywarren!! I'm facing some issue in my environment setup, I'm working on it, will open a PR as soon as I get it ready..

@ishikajn8126 some screenshots of the issue would be helpful. Can you share the issue with us.

[ishikajn8126]

Hey @stephaniequintana @jywarren!! I'm facing some issue in my environment setup, I'm working on it, will open a PR as soon as I get it ready..

@ishikajn8126 some screenshots of the issue would be helpful. Can you share the issue with us.

Hey @Forchapeatl, here is the ss of the issue that I was facing...
I've got it resolved now!
Thanks a lot for concern!!

[Forchapeatl]

Hey @stephaniequintana @jywarren!! I'm facing some issue in my environment setup, I'm working on it, will open a PR as soon as I get it ready..

@ishikajn8126 some screenshots of the issue would be helpful. Can you share the issue with us.

Hey @Forchapeatl, here is the ss of the issue that I was facing... I've got it resolved now! Thanks a lot for concern!!

your welcome