-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tag Popover Text #10987
Comments
Reserved for @helenalvp for 24 hours!! |
* Removed duplicate code publiclab#10897 * Removed duplicate code publiclab#10897 * Indented Line * Removed Duplicate Code publiclab#10897 Fix Indented line publiclab#5 to be on same line as publiclab#10 * Removed Duplicate Code publiclab#10897 Fix Indented line publiclab#5 to be on same line as publiclab#10 * Indentation on publiclab#5 fix * Removed Duplicate Code publiclab#10897 Fix Indented line publiclab#5 to be on same line as publiclab#10 * Removed duplicate code publiclab#10897 Removed Duplicate code publiclab#10987 Indenting Line publiclab#5 * Removed Duplicate Code publiclab#10897 Fix Indented line publiclab#5 to be on same line as publiclab#10 * Indentation on publiclab#5 fix * Removed Duplicate Code publiclab#10897 Fix Indented line publiclab#5 to be on same line as publiclab#10 * Removed duplicate code publiclab#10897 Removed Duplicate code publiclab#10987 Indenting Line publiclab#5 * Removed Duplicate Code publiclab#10897 Fix Indented line publiclab#5 to be on same line as publiclab#10 * Indentation on publiclab#5 fix * Removed duplicate code publiclab#10897 * Indented Line * Removed duplicate code publiclab#10897
Hi! Thank you for the issue! |
Hi @helenalvp, do you need help with this? |
Hi! I apologize for the late response. When I was trying to work on it this week, my computer wouldn't start, and I had to take it to the shop. I'm picking it up in a couple of hours after work, and should have this issue cleared if not tonight then by tomorrow |
Hey @helenalvp, have you opened a pull request already? If not then I'd like to work on this issue with you. |
Hi @TildaDares can I contribute to this? |
@TildaDares It looks like my hardware situation isn't going to improve anytime soon. Please give this issue to the next person that's waiting to contribute. Thank you. |
I’m sorry to hear that @helenalvp. |
Hi @NikitaKhabya, you can take this up. Thanks! |
Hi @TildaDares Can you please assign me this issue? |
Hi @NikitaKhabya, are you still interested in working on this? |
Hi @TildaDares Can you please assign me this issue? I am an outreachy applicant. |
This issue is open for anyone to work on. |
Hi @TildaDares, can I claim this? |
Hi @guyinmanhattan2021, please go ahead. Thank you!! |
Hi @TildaDares, can I ask for some help? I've completed steps 1-4 of the readme.md, but I haven't worked with Ruby before. I'm using Windows. Cou;d you give me some guidance? |
Hello @guyinmanhattan2021. If you are facing problem in installing plots2 on your local machine then I suggest you to use gitpod for making your first-time contribution. Because for windows users it is very hard and time taking to run plots2 locally. Also if you face any problem using gitpod then you can take the help of the instructions given here. All the best! |
Hi @guyinmanhattan2021, sure I can help. Can you tell me what the problem is exactly? |
Reassigning this. |
Reserved for @fedechaves for 24 hours! |
Update Tag Popover Text publiclab#10987 Changes in line 18
Thank you very much @TildaDares ! Changes were committed and pulled for review |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
💡 Learn how to claim 🙋
Claiming an issue
Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.
And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.
plots2
repository (press the little pen Icon) and edit the line as shown below.See this page for some help in taking your first steps!
Below is a "diff" showing in red (and a
-
) which lines to remove, and in green (and a+
) which lines to add:@@ -15,7 +15,7 @@ <p style="margin-top:14px;"><%= render partial: 'tag/miniCard', locals: { tag: tag, grey: power_tag } %></p> <% else %> - <p class="badge <%= badge_name %> pop more-tags" style="<% if power_tag %>background-color:rgb(102,102,102);<% else %>background-color:rgb(0,123,255);<% end %>display:none;cursor:pointer;margin-bottom:3px;" id="tag_<%= tag.tid %>" data-toggle="popover" data-trigger="focus" data-count=0 data-placement="top" data-content="<p style='text-align:center;'>This is a <% if (tag.name.include?('lat:') || tag.name.include?('lon:')) %><a href='https://publiclab.org/location-privacy'>geographic tag</a><% elsif tag.name.include? ':' %><a href='https://publiclab.org/power-tags'>power tag</a>.<% end %><br><a href='/tag/<%= tag.name %>'><%= Tag.tagged_node_count(tag.name) || 0 %> notes</a> - <a href='/contributors/<%= tag.name %>'><%= Tag.contributors(tag.name).count %> people <br></a></p> <p style='text-align:center;font-size:12px;'><%if tag.description %><%= tag.description %> |<% end %> created by <a href='/profile/<%= tag.try(:author).try(:username) %>'><%= tag.try(:author).try(:username) %></a> <%= time_ago_in_words(Time.at(tag.date)) %> ago </p><div class='text-center'><a href='/subscribe/tag/<%= tag.name %>' class='btn btn-primary'>Follow</a></div>" data-html="true" title="<%= tag.name %>"> + <p class="badge <%= badge_name %> pop more-tags" style="<% if power_tag %>background-color:rgb(102,102,102);<% else %>background-color:rgb(0,123,255);<% end %>display:none;cursor:pointer;margin-bottom:3px;" id="tag_<%= tag.tid %>" data-toggle="popover" data-trigger="focus" data-count="0" data-placement="top" data-content="<p style='text-align:center;'><% if (tag.name.include?('lat:') || tag.name.include?('lon:')) %>This is a <a href='https://publiclab.org/location-privacy'>geographic tag</a><% elsif tag.name.include? ':' %>This is a <a href='https://publiclab.org/power-tags'>power tag</a>.<% end %><br><a href='/tag/<%= tag.name %>'><%= Tag.tagged_node_count(tag.name) || 0 %> notes</a> - <a href='/contributors/<%= tag.name %>'><%= Tag.contributors(tag.name).count %> contributors <br></a></p> <p style='text-align:center;font-size:12px;'><%if tag.description %><%= tag.description %> |<% end %> created by <a href='/profile/<%= tag.try(:author).try(:username) %>'><%= tag.try(:author).try(:username) %></a> <%= time_ago_in_words(Time.at(tag.date)) %> ago </p><div class='text-center'><a href='/subscribe/tag/<%= tag.name %>' class='btn btn-primary'>Follow</a></div>" data-html="true" title="<%= tag.name %>"> <a class='tag-name' href='/tag/<%= tag.name %>'><%= tag.name %></a> <% if logged_in_as(['admin', 'moderator']) || (current_user && ( current_user.uid == @node.uid || current_user.uid == tag.uid)) %> <% if tag.name.include? ':' %>
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.
👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
🤔❓ Questions?
Leave a comment below, and reach out in our chatroom!
The text was updated successfully, but these errors were encountered: