-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SASS changes in mixed declarations #1952
Comments
are they expected to behave differently at runtime, or only going to matter for things like readability of the compiled CSS file and/or webpack's ability to minimize file size? Looking at the page you linked, I can see that the compiled CSS looks a bit different, but I'd expect them to behave the same way. I know later declarations can override earlier ones, but in this case |
I agree, their example doesn't illustrate any particular problem, as far as I can tell. Let me investigate a bit more; I presume they wouldn't publish it as a deprecation if it didn't have an impact. |
I can't come up with an example right now, so I asked on the original dart-sass issue: sass/dart-sass#2267 (comment) |
They provided an example today: .example {
color: red;
@media screen {
font-weight: bold;
}
font-weight: normal;
} |
When compiling the style files from PDST using dart-sass, it emits warnings related to changes is how SASS will deal in the future with mixed declarations.
Short story, before a declaration like:
Would pull
font-weight
to the top of.example
, and definea font-weight
after. Now, they leave the ordering alone.At least the following cases are present in PDST:
The workaround? As Dart Sass reports:
The text was updated successfully, but these errors were encountered: