Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] make DiscreteHMCGibbs plate aware #1406

Open
martinjankowiak opened this issue May 14, 2022 · 1 comment
Open

[FR] make DiscreteHMCGibbs plate aware #1406

martinjankowiak opened this issue May 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@martinjankowiak
Copy link
Collaborator

afaik DiscreteHMCGibbs does not make use of plate information when computing Gibbs updates for discrete latent variables. it would be nice to support this, as leveraging this information can make Gibbs steps exponentially cheaper

@martinjankowiak martinjankowiak added enhancement New feature or request discussion labels May 14, 2022
@fehiepsi
Copy link
Member

This sounds possible. I think we can perform discrete update in blocks (maybe #898 is helpful) where in each block, we can decide which strategy we want (i.e. using current DiscreteHMCGibbs strategy or plate-aware strategy). For plate-aware, I guess we just need to maintain plate-information of each factor, remove unnecessary factors (based on provenance?), then perform the gibbs update in one pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants