Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyrra kubernetes doesn't completely log as json #1306

Open
sebastiangaiser opened this issue Oct 22, 2024 · 0 comments
Open

pyrra kubernetes doesn't completely log as json #1306

sebastiangaiser opened this issue Oct 22, 2024 · 0 comments

Comments

@sebastiangaiser
Copy link
Contributor

sebastiangaiser commented Oct 22, 2024

Hey, thank you for this amazing project and seeing updates on it now again.

I configured pyrra api and pyrra kubernetes to log as json by adding --log-format=json to the args. Unfortunately pyrra kubernetes doesn't log everything as json:

pyrra-kubernetes 2024-10-22T13:09:52Z    INFO    setup    starting manager                                                                                                                                                                                                                              
pyrra-kubernetes 2024-10-22T13:09:52Z    INFO    controller-runtime.metrics    Starting metrics server                                                                                                                                                                                                  
pyrra-kubernetes 2024-10-22T13:09:52Z    INFO    controller-runtime.metrics    Serving metrics server    {"bindAddress": ":8080", "secure": false}                                                                                                                                                      
pyrra-kubernetes 2024-10-22T13:09:52Z    INFO    Starting EventSource    {"controller": "servicelevelobjective", "controllerGroup": "pyrra.dev", "controllerKind": "ServiceLevelObjective", "source": "kind source: *v1alpha1.ServiceLevelObjective"}                                                   
pyrra-kubernetes 2024-10-22T13:09:52Z    INFO    Starting Controller    {"controller": "servicelevelobjective", "controllerGroup": "pyrra.dev", "controllerKind": "ServiceLevelObjective"}                                                                                                              
pyrra-kubernetes 2024-10-22T13:09:52Z    INFO    Starting workers    {"controller": "servicelevelobjective", "controllerGroup": "pyrra.dev", "controllerKind": "ServiceLevelObjective", "worker count": 1}                                                                                              
pyrra-kubernetes {"caller":"servicelevelobjective.go:55","controllers":"ServiceLevelObjective","level":"debug","msg":"reconciling","namespace":"monitoring/my-sso","reconciler":"servicelevelobjective","ts":"2024-10-22T13:09:52.218404029Z"}                                                          
pyrra-kubernetes {"caller":"servicelevelobjective.go:89","controllers":"ServiceLevelObjective","level":"info","msg":"updating prometheus rule","name":"my-sso","namespace":"monitoring","reconciler":"servicelevelobjective","ts":"2024-10-22T13:09:52.319891099Z"}

It would be great to have everything as json because otherwise the log parsing even "harder".

Just to have it mentioned, I enabled --log-level=debug, too.

@sebastiangaiser sebastiangaiser changed the title Pyrra Kubernetes not completely logging as json pyrra kubernetes doesn't completely log as json Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant