Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using typing.Annotated #1275

Closed
AdrianSosic opened this issue Apr 8, 2024 · 5 comments
Closed

Using typing.Annotated #1275

AdrianSosic opened this issue Apr 8, 2024 · 5 comments
Labels
Typing Typing/stub/Mypy/PyRight related bugs.

Comments

@AdrianSosic
Copy link

Hi, I'm not sure if this has been already discussed in some other context (and please just close if this is a duplicate) but I was wondering if there is already some debate on whether or not it makes sense to also support using typing.Annotated for attrs. For example, I've seen that pydantic uses the mechanism to allow binding validation to types instead of attributes, which I think is a neat concept that allows reusing the same semantic meaning across different contexts/classes. And I've already had several situations in my code where such a mechanism would have been useful, e.g. when attributes of different classes should undergo the exact same conversion/validation logic.

Are there any plans for this in attrs already?

@hynek
Copy link
Member

hynek commented Apr 9, 2024

There's no plans underway, no. The whole field seems also a bit in flux tbh but @Tinche might have opinions.

@hynek hynek added the Typing Typing/stub/Mypy/PyRight related bugs. label May 8, 2024
@AdrianSosic
Copy link
Author

We've just added another module to our code where the same combination of type hint + field definition is repeated all over the place, which again reminded me of how useful the typing.Annotated could be in many situations. Just wanted to ask again if the two of you already could make your minds about whether you see this on the roadmap or not. I think it would also help many people transition from pydantic to attrs, who are already used to that syntax, in fact ...

@dlax
Copy link
Contributor

dlax commented May 21, 2024

Duplicate of #775

@AdrianSosic
Copy link
Author

Hi @dlax, thanks for tagging!

@hynek
Copy link
Member

hynek commented Jul 24, 2024

closing in favor of #775

@hynek hynek closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing Typing/stub/Mypy/PyRight related bugs.
Projects
None yet
Development

No branches or pull requests

3 participants