Support @deprecated() on overloaded __get__ for generic descriptors
#18333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
5 tasks
This comment has been minimized.
This comment has been minimized.
Viicos
force-pushed
the
deprecated-generic-descriptors
branch
from
3e0684b to
8ca2a14
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
A5rocks
reviewed
Dec 28, 2024
| @@ -7724,7 +7729,9 @@ def warn_deprecated_overload_item( | |||
| candidate := item.func.type, CallableType | |||
| ): | |||
| if selftype is not None: | |||
| candidate = bind_self(candidate, selftype) | |||
| candidate = bind_self( | |||
There was a problem hiding this comment.
I'm a bit surprised about this bind_self, actually. I cannot find where inferred_dunder_get_type gets passed to bind_self... I'm only looking at the code though. I'm certain it's used but... where?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18323.
Follow up on #18090.
Notes:
analyze_descriptor_access, there is a distinction betweentypanddescriptor_type:mypy/mypy/checkmember.py
Lines 687 to 688 in 9ff9946
map_instance_to_supertypereturnsdescriptor_typeunchanged. The reason I'm mentioning this is thatexpand_type_by_instanceusestypand notdescriptor_type. Inwarn_deprecated_overload_item, we have access todescriptor_type(passed asselftype):mypy/mypy/checkmember.py
Lines 726 to 728 in 9ff9946
expand_type_by_instance(candidate, selftype). Is this going to be an issue?selftypetoInstance. Is this going to be an issue?