allow enabling the extension using quarkus.log.sentry.enabled key #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Nov 20, 2024
| * Determine whether to enable the Sentry logging extension. | ||
| */ | ||
| @ConfigItem | ||
| public Optional<Boolean> enabled; |
There was a problem hiding this comment.
FWIW I think it makes sense to avoid this ~ YAML trick. It causes all sorts of issues.
Ideally, I think it should be active though if we want to follow the convention we use in the core. enabled is for enabling/disabling the extension at build time. active is for activating/deactivating the behavior at runtime. I think it's more the latter in this case, right?
@ia3andy WDYT?
If we include this one, could you mark the old one as deprecated so that the doc is not confusing?
There was a problem hiding this comment.
@rmanibus could you rename to active and add deprecated to the other config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #253