Fix RawString issue with Asciidoc and Markdown template extensions #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtama
approved these changes
Dec 20, 2024
mkouba
requested changes
Jan 2, 2025
| import io.quarkus.qute.SectionHelperFactory; | ||
| import io.quarkus.qute.SingleResultNode; | ||
| import io.quarkus.qute.TemplateExtension; | ||
| import io.quarkus.qute.*; |
There was a problem hiding this comment.
Pls don't use wildcards for imports.
| @@ -29,8 +23,8 @@ public AsciidocSectionHelper initialize(SectionInitContext context) { | |||
| } | |||
|
|
|||
| @TemplateExtension(matchNames = { "asciidocify", "asciidocToHtml" }) | |||
| static String convertToAsciidoc(String text, String ignoredName) { | |||
| return CONVERTER.apply(text); | |||
| static RawString convertToAsciidoc(String text, String ignoredName) { | |||
There was a problem hiding this comment.
How does it fix the problem with section params in #146?
IIUIC this merely changes the behavior of {text.asciidocToHtml} in a way that it corresponds to {text.asciidocToHtml.raw}. Which is probably ok, unless someone wants to escape the result of conversion... which probably does not make a lot of sense, right?
There was a problem hiding this comment.
What I was trying to achieve with an attribute was to prevent the the rendered content of beeing escaped. So if we have another to achieve the same it's fine.
It may be still be of some use to be able to pass attributes to the section but this would be a good start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146