Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting markdown table #296

Open
jotak opened this issue Nov 28, 2024 · 7 comments
Open

Supporting markdown table #296

jotak opened this issue Nov 28, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@jotak
Copy link
Contributor

jotak commented Nov 28, 2024

Hi roq team,
As far as I can tell, there's no support currently for markdown tables such as that:

  | Time Range | Response time
  | :--------: | :-------:
  | Last 5m    | 984 ms
  | Last 1h    | 2410 ms
  | Last 6h    | > 10 s

which, for instance in github markdown, renders as:

Time Range Response time
Last 5m 984 ms
Last 1h 2410 ms
Last 6h > 10 s

Would it be possible to introduce such support? Is it something that has to be done upstream/FrontMatter , or can it be done directly in roq?

Current workaround is to write direct html:

<table>
<thead>
<tr>
<th>Time Range</th>
<th>Response time</th>
</tr>
</thead>
<tbody>
<tr>
<td>Last 5m</td>
<td>984 ms</td>
</tr>
<tr>
<td>Last 1h</td>
<td>2410 ms</td>
</tr>
<tr>
<td>Last 6h</td>
<td>> 10 s</td>
</tr>
</tbody>
</table>
@jotak
Copy link
Contributor Author

jotak commented Nov 28, 2024

PS: I'm happy to contribute such feature in roq if you want & can provide some help about how/where to do this

@melloware
Copy link
Contributor

PR are welcome!

@melloware melloware added the enhancement New feature or request label Nov 28, 2024
@ia3andy
Copy link
Contributor

ia3andy commented Dec 2, 2024

I think we need to switch our default markdown to this: quarkiverse/quarkus-qute-web#137, they have the table extension

@ia3andy
Copy link
Contributor

ia3andy commented Dec 2, 2024

ah commonmark also have it https://github.com/commonmark/commonmark-java/tree/main/commonmark-ext-gfm-tables, the the https://github.com/vsch/flexmark-java seems to have more extensions.

@mcruzdev
Copy link
Member

mcruzdev commented Dec 2, 2024

ah commonmark also have it https://github.com/commonmark/commonmark-java/tree/main/commonmark-ext-gfm-tables

Yes, I was going to say that.

@jotak You can add it on quarkus-qute-web first.

@melloware
Copy link
Contributor

I have used CommonMark before but I am OK with whatever library is the most supported and is still getting commits!

@ia3andy
Copy link
Contributor

ia3andy commented Dec 2, 2024

It seems flexmark-java is not maintained anymore (PR not getting merged, no recent release, unanswered issues).. too bad it seemed to be more complete..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants