Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to authenticate with a Github token? #73

Open
r00ta opened this issue Sep 1, 2022 · 5 comments
Open

Is it possible to authenticate with a Github token? #73

r00ta opened this issue Sep 1, 2022 · 5 comments

Comments

@r00ta
Copy link

r00ta commented Sep 1, 2022

Hi team,

I'm trying to login with a Github token but I can't find the configuration to do it https://quarkiverse.github.io/quarkiverse-docs/quarkus-vault/dev/index.html#configuration-reference.

The Vault documentation about this authentication mechanism is here https://www.vaultproject.io/api-docs/auth/github.

Is it already available or it a missing feature?

Thank you so much 🙏

@sberyozkin
Copy link
Contributor

@r00ta How is screen activated given that quarkus-vault has no OIDC/OAuth2 integration ?

@r00ta
Copy link
Author

r00ta commented Sep 3, 2022

@r00ta How is screen activated given that quarkus-vault has no OIDC/OAuth2 integration ?

Hi @sberyozkin , the screenshot is just to show that on the vault UI it's possible to login with a gh token. Yesterday I sent a draft PR with this new integration to get your initial feedbacks on it

@sberyozkin
Copy link
Contributor

Hi @r00ta I've looked at the PR and have not seen the code which redirects the user to this screen.
I wonder if quarkusio/quarkus#13817 is related

@r00ta
Copy link
Author

r00ta commented Sep 3, 2022

Hi @r00ta I've looked at the PR and have not seen the code which redirects the user to this screen.
I wonder if quarkusio/quarkus#13817 is related

There is no redirection to that webpage. When I opened the issue I just wanted to highlight the fact that there are multiple ways to authenticate to the vault, for example the GitHub token.
In order to login to the vault using the gh token I'm using the vault API (no webpages/oidc/redirection involved at all)

@r00ta
Copy link
Author

r00ta commented Sep 5, 2022

Hi @r00ta I've looked at the PR and have not seen the code which redirects the user to this screen. I wonder if quarkusio/quarkus#13817 is related

I've updated the issue description so to clarify the misunderstanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants