Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement memory management for the standalone functions cache #75

Open
dumbbell opened this issue Apr 1, 2022 · 3 comments
Open

Implement memory management for the standalone functions cache #75

dumbbell opened this issue Apr 1, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@dumbbell
Copy link
Member

dumbbell commented Apr 1, 2022

In #72, we introduce a cache for already extracted standalone functions to improve performances.

Currently, this cache will grow indefinitely. We need some kind of policy to clean it up.

@dumbbell dumbbell added the enhancement New feature or request label Apr 1, 2022
@the-mikedavis
Copy link
Member

What would you think about an ETS-based LRU cache for this? Would you be open to a contribution?

@michaelklishin
Copy link
Member

In other RabbitMQ projects where we have a cache, it is sometimes an interface that you can implement however you like and configure a module to be used. Maybe it's an overkill for Khepri but there is no single best way to do K/V caching in process, so an interface makes certain sense to me. Our first implementation can be ETS-based :)

@dumbbell
Copy link
Member Author

dumbbell commented Apr 5, 2022

What would you think about an ETS-based LRU cache for this? Would you be open to a contribution?

Yes, feel free to experiment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants