Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.json needs an updated version of Amphion #89

Open
wolfv opened this issue Jun 11, 2020 · 3 comments
Open

Package.json needs an updated version of Amphion #89

wolfv opened this issue Jun 11, 2020 · 3 comments

Comments

@wolfv
Copy link
Contributor

wolfv commented Jun 11, 2020

When trying to build with the current version of Amphion, it fails to add any topic because of missing RosTopicDataSource.
Upping Amphion to the latest makes everything work fine.

@tony2guo
Copy link

tony2guo commented Sep 2, 2020

After I add a visualization, I got this error in devel branch:

react-dom.production.min.js:196 TypeError: y.a.RosTopicDataSource is not a constructor
at xv (index.js:11)
at Function.value (index.jsx:181)
at t.value (index.jsx:266)
at t.value (index.jsx:202)
at jl (react-dom.production.min.js:251)
at t.unstable_runWithPriority (scheduler.production.min.js:18)
at Yi (react-dom.production.min.js:120)
at Ll (react-dom.production.min.js:244)
at xl (react-dom.production.min.js:223)
at react-dom.production.min.js:121

and this in feature/rosbag_datasource branch:

react-dom.production.min.js:193 TypeError: Expected 'val' to be MeshBasicMaterial
at P (amphion.js:1)
at jt (amphion.js:1)
at t.setColor (amphion.js:1)
at new t (amphion.js:1)
at Function.value (index.jsx:151)
at t.value (index.jsx:279)
at t.value (index.jsx:218)
at Sl (react-dom.production.min.js:249)
at t.unstable_runWithPriority (scheduler.production.min.js:18)
at Vi (react-dom.production.min.js:119)

@seadeep42
Copy link
Contributor

This is fixed in a fork of the repo with npm packages available at @robostack/zethus and @robostack/amphion.

Commit for reference:
RoboStack@fcebf45#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R24

@tony2guo
Copy link

tony2guo commented Sep 2, 2020

This is fixed in a fork of the repo with npm packages available at @robostack/zethus and @robostack/amphion.

Commit for reference:
RoboStack@fcebf45#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R24

Thank you! It works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants