embedded: Use blconfig alias to find bootloader config #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tdewey-rpi Comparing this to the https://github.com/raspberrypi/rpi-eeprom/blob/master/rpi-eeprom-update#L117 that @timg236 linked to in #894 , it looks like your're doing the local blconfig_alias="/sys/firmware/devicetree/base/aliases/blconfig"and local blconfig_ofnode_link=$(find -L /sys/bus/nvmem -maxdepth 3 -samefile "${blconfig_ofnode_path}" 2>/dev/null)parts, but you seem to be missing out the local blconfig_ofnode_path="/sys/firmware/devicetree/base"$(strings "${blconfig_alias}")""part in the middle? 🤔 |
tdewey-rpi
force-pushed
the
dev/tdewey/bugs/894
branch
from
c7774cf to
6c1a3fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the blconfig alias to find the correct nvmem device to read the bootloader configuration, the practical effect being that IMAGER_REPO_URL should work on Raspberry Pi 5.
Fixes #894