Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding RDKit to the package dependencies #67

Open
ESRE-dev opened this issue Nov 11, 2024 · 2 comments
Open

Consider adding RDKit to the package dependencies #67

ESRE-dev opened this issue Nov 11, 2024 · 2 comments

Comments

@ESRE-dev
Copy link

For I pip installable Python package, I'd always expect that all dependencies are defined and do not have to be installed additionally.

When installing mmpdb in a clean venv, RDKit is currently missing on my system. Is this on purpose?

Can it be added to the setup.cfg file?

@adalke
Copy link
Contributor

adalke commented Nov 11, 2024 via email

@ESRE-dev
Copy link
Author

Hi Andrew,
thank you for still reaching out even though you are not the maintainer anymore. Yeah, it would be great if the whole repository would be migrated to pyproject.toml. But adding it to the setup.cfg seemed liked a good quick fix.

Thanks for the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants