Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTransition appearDone being unset causes "undefined" class when in+appear are true first and enterDone is set #890

Open
stevensacks opened this issue Jun 19, 2023 · 0 comments

Comments

@stevensacks
Copy link

stevensacks commented Jun 19, 2023

What is the current behavior?

If in and appear are true on first render, and classNames contains a value for enterDone and you do not provide appearDone, you get an undefined class.

Having appear set in classNames does not prevent undefined from being included. If you have enterDone and do not include appearDone, you get undefined.

What is the expected behavior?

Do not inject "undefined" class names (in any situation, not just this one).

Could you provide a CodeSandbox demo reproducing the bug?

https://codesandbox.io/s/blazing-tdd-dlmmk3?file=/src/App.js

I made a css class which turns text red so you can see visually when undefined is being included.

.undefined {
    color: #f00;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant