fix: panic on cluster redirection to a node with stale role #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
fix-cluster-redirection-panic-on-stale-role
branch
3 times, most recently
from
c42a54a to
084671c
Compare
Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
fix-cluster-redirection-panic-on-stale-role
branch
from
084671c to
d29cbfd
Compare
proost
approved these changes
Dec 12, 2024
Signed-off-by: Rueian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694
The situation happened when a cluster node got promoted to be the primary and the client followed a
MOVEDredirection but still think the node as a replica. Then the client set the connection to therslotswhich was not yet initialized. This PR changes two things:connrole.replicafield because, in the future, a node can have mixed roles. [NEW] Primary replica role at the slot level valkey-io/valkey#1372MOVEDredirection. ie. It always points to the primary of the slot so the client should set the connection topslotsdirectly.Hi @proost, could you help review this?